pvary commented on code in PR #9308:
URL: https://github.com/apache/iceberg/pull/9308#discussion_r1431258224


##########
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceWithWatermarkExtractor.java:
##########
@@ -383,8 +381,10 @@ protected IcebergSource<RowData> source() {
         .project(TestFixtures.TS_SCHEMA)
         .splitSize(100L)
         .streaming(true)
-        .monitorInterval(Duration.ofMillis(2))
+        .monitorInterval(Duration.ofMillis(100))
         
.streamingStartingStrategy(StreamingStartingStrategy.TABLE_SCAN_THEN_INCREMENTAL)
+        // Read in single row batches, to have more batches for testing
+        .flinkConfig(new 
Configuration().set(SOURCE_READER_FETCH_BATCH_RECORD_COUNT, 1))

Review Comment:
   Nope. This is needed for higher probability for hitting 
`pauseOrResumeSplits` and friends. Since the fetching is done in batches, 
having 1 record per batch allows us to have more fetch cycles - bigger 
probability to run into the blocking/unblocking situations.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to