chenjunjiedada commented on a change in pull request #1101:
URL: https://github.com/apache/iceberg/pull/1101#discussion_r438453978
##########
File path: core/src/test/java/org/apache/iceberg/TestMergeAppend.java
##########
@@ -183,31 +183,97 @@ public void testManifestMergeMinCount() throws
IOException {
TableMetadata base = readMetadata();
Assert.assertNull("Should not have a current snapshot",
base.currentSnapshot());
+ V2Assert.assertEquals("Last sequence number should be 0", 0,
readMetadata().lastSequenceNumber());
+ V1Assert.assertEquals("Table should end with last-sequence-number 0", 0,
base.lastSequenceNumber());
ManifestFile manifest = writeManifest(FILE_A);
ManifestFile manifest2 = writeManifestWithName("FILE_C", FILE_C);
ManifestFile manifest3 = writeManifestWithName("FILE_D", FILE_D);
+ ManifestFile manifest4 = writeManifestWithName("FILE_B", FILE_B);
table.newAppend()
.appendManifest(manifest)
.appendManifest(manifest2)
.appendManifest(manifest3)
.commit();
+ Snapshot snap1 = table.currentSnapshot();
+ long commitId1 = snap1.snapshotId();
+ base = readMetadata();
Assert.assertEquals("Should contain 2 merged manifest for first write",
2, readMetadata().currentSnapshot().allManifests().size());
+ validateManifest(snap1.allManifests().get(0),
Review comment:
OK, I see the new validate method, will replace them with the new one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
