manuzhang commented on code in PR #9400:
URL: https://github.com/apache/iceberg/pull/9400#discussion_r1442954829
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java:
##########
@@ -345,7 +345,7 @@ private Result doExecuteWithPartialProgress(
.noRetry()
.onFailure(
(fileGroup, exception) -> {
- LOG.error("Failure during rewrite group {}", fileGroup.info(),
exception);
+ LOG.warn("Failure during rewrite group {}", fileGroup.info(),
exception);
Review Comment:
I agree ERROR is better for non-partial case. For partial progress, since
failure is allowed, WARN sends the signal that failure is not fatal to the
whole procedure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
