ZENOTME commented on issue #159:
URL: https://github.com/apache/iceberg-rust/issues/159#issuecomment-1882940112
> Add a new type Datum which is self contained primitive value, it can be
implemented as following
This idea looks good to me. But I'm concerned about the conversion effort
for two representations. e.g. The user uses expr Decimal(Decimal), and the
partition value in the data file is Decimal(i128). Then we should make an
effort to convert them and compare them. And we also should deal with the case
that if Decimal(Decimal) is i256.
The Datum seems like Literal with type info, so I think a new
representationš¤:
```
struct Datum {
ty: DataType,
value: Literal
}
```
The benefit of this may be less compatible effort. To make user-facing APIs
more simplified, maybe we can let the user provide Decimal and convert it into
`Literal + DataType` in the inner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
