pvary commented on code in PR #8907:
URL: https://github.com/apache/iceberg/pull/8907#discussion_r1447409989
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -142,9 +143,15 @@ public FileIO io() {
@Override
protected void doRefresh() {
String metadataLocation = null;
+ Table table = null;
+
try {
- Table table = metaClients.run(client -> client.getTable(database,
tableName));
- HiveOperationsBase.validateTableIsIceberg(table, fullName);
+ table = metaClients.run(client -> client.getTable(database, tableName));
+ HiveOperationsBase.validateTableOrViewIsIceberg(table, fullName);
+
+ if
(table.getTableType().equalsIgnoreCase(TableType.VIRTUAL_VIEW.name())) {
Review Comment:
IIRC the decision was to do not use the HMS tableType for this. Shouldn't we
use `BaseMetastoreTableOperations.TABLE_TYPE_PROP` property instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
