cmathiesen commented on a change in pull request #933: URL: https://github.com/apache/iceberg/pull/933#discussion_r439544211
########## File path: mr/src/main/java/org/apache/iceberg/mr/mapred/iterables/SnapshotIterable.java ########## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.mr.mapred.iterables; + +import java.io.IOException; +import java.util.ArrayList; +import java.util.List; +import org.apache.iceberg.Snapshot; +import org.apache.iceberg.Table; +import org.apache.iceberg.data.GenericRecord; +import org.apache.iceberg.data.Record; +import org.apache.iceberg.io.CloseableIterable; +import org.apache.iceberg.io.CloseableIterator; + +/** + * Creates an Iterable of Records with all snapshot metadata that can be used with the RecordReader. + */ +public class SnapshotIterable implements CloseableIterable { Review comment: The reason we ended up adding the `SnapshotIterable` is so we could wrap a row from the SnapshotsTable in a `Record` which could be passed back to the `RecordReader` without needing to change any code for the RR. It could be super helpful if there was a method in `SnapshotsTable` that returned Records for the whole table, as there isn't a Reader, so to speak, for the `METADATA` file format (https://github.com/apache/iceberg/blob/master/api/src/main/java/org/apache/iceberg/FileFormat.java#L31) that we can add in to the `ReaderFactory` that would allow us 'read' from the SnapshotTable ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
