rdblue commented on a change in pull request #828:
URL: https://github.com/apache/iceberg/pull/828#discussion_r439680812
##########
File path:
spark/src/test/java/org/apache/iceberg/spark/data/parquet/vectorized/TestParquetVectorizedReads.java
##########
@@ -48,11 +48,15 @@
import static org.apache.iceberg.types.Types.NestedField.required;
public class TestParquetVectorizedReads extends AvroDataTest {
- private static final int NUM_ROWS = 1_000_000;
+ private static final int NUM_ROWS = 200_000;
@Override
protected void writeAndValidate(Schema schema) throws IOException {
- writeAndValidate(schema, NUM_ROWS, 0L, RandomData.DEFAULT_NULL_PERCENTAGE,
false, true);
+ writeAndValidate(schema, getNumRows(), 0L,
RandomData.DEFAULT_NULL_PERCENTAGE, false, true);
+ }
+
+ protected int getNumRows() {
+ return NUM_ROWS;
Review comment:
Why make this a method? So it can be overridden?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
