jun-he commented on pull request #922: URL: https://github.com/apache/iceberg/pull/922#issuecomment-643828752
@rdblue Thanks for the comments and I updated the PR accordingly. In the PR, I still keep the lazily reassign the partition field ids if needed during commit instead of tracking field Id during the add fields. The main reason is to reduce the duplicate code between `PartitionSpec` and `PartitionSpecUpdate`. If completely maintaining a List of PartitionField here, we then have to keep the duplicate logic in `PartitionSpec.Builder`, e.g. from `sourceName` to `sourceId`, from method name to get `Transform`, from source name to get the default partition name. Instead, I maintain a list of `PartitionField` for the fields from the current spec and then maintain a List of `Consumer<PartitionSpec.Builder>` for the newly added fields. Please take a look and let me know your comments. Thanks! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
