rdblue commented on a change in pull request #1115:
URL: https://github.com/apache/iceberg/pull/1115#discussion_r441035067
##########
File path: core/src/main/java/org/apache/iceberg/DataFilesTable.java
##########
@@ -76,24 +74,17 @@ public Schema schema() {
this.fileSchema = fileSchema;
}
- private FilesTableScan(
- TableOperations ops, Table table, Long snapshotId, Schema schema,
Expression rowFilter,
- boolean ignoreResiduals, boolean caseSensitive, boolean colStats,
- Collection<String> selectedColumns, Schema fileSchema,
ImmutableMap<String, String> options) {
- super(
- ops, table, snapshotId, schema, rowFilter, ignoreResiduals,
- caseSensitive, colStats, selectedColumns, options);
+ private FilesTableScan(TableOperations ops, Table table, Schema schema,
Schema fileSchema,
+ TableScanContext context) {
+ super(ops, table, schema, context);
this.fileSchema = fileSchema;
}
@Override
- protected TableScan newRefinedScan(
- TableOperations ops, Table table, Long snapshotId, Schema schema,
Expression rowFilter,
- boolean ignoreResiduals, boolean caseSensitive, boolean colStats,
Collection<String> selectedColumns,
- ImmutableMap<String, String> options) {
+ protected TableScan newRefinedScan(TableOperations ops, Table table,
Schema schema,
+ TableScanContext context) {
Review comment:
Nit: Does this need a newline?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
