rdblue commented on a change in pull request #922:
URL: https://github.com/apache/iceberg/pull/922#discussion_r441203899
##########
File path: core/src/test/java/org/apache/iceberg/TestPartitionSpecParser.java
##########
@@ -40,26 +55,24 @@ public void testToJsonForV1Table() {
"}";
Assert.assertEquals(expected, PartitionSpecParser.toJson(table.spec(),
true));
- PartitionSpec spec = PartitionSpec.builderFor(table.schema())
- .bucket("id", 8)
- .bucket("data", 16)
- .build();
-
- table.ops().commit(table.ops().current(),
table.ops().current().updatePartitionSpec(spec));
+ table.updateSpec().clear()
+ .addBucketField("id", 8)
+ .addBucketField("data", 16)
+ .commit();
Review comment:
Why does this test use a table? It would make more sense to me if it
created a custom partition spec (using add to set field IDs directly) and
checked the resulting JSON string, without using update or a table at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
