nastra commented on code in PR #9565:
URL: https://github.com/apache/iceberg/pull/9565#discussion_r1469643916
##########
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/sink/TestRowDataPartitionKey.java:
##########
@@ -91,10 +92,10 @@ public void testNullPartitionValue() {
for (RowData row : rows) {
PartitionKey partitionKey = new PartitionKey(spec, schema);
partitionKey.partition(rowWrapper.wrap(row));
- Assert.assertEquals(partitionKey.size(), 1);
+ assertThat(partitionKey.size()).isEqualTo(1);
String expectedStr = row.isNullAt(1) ? null :
row.getString(1).toString();
- Assert.assertEquals(expectedStr, partitionKey.get(0, String.class));
+ assertThat(expectedStr).isEqualTo(partitionKey.get(0, String.class));
Review Comment:
the ordering of actual/expected needs to be fixed here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
