massdosage commented on a change in pull request #1103:
URL: https://github.com/apache/iceberg/pull/1103#discussion_r441650372
##########
File path:
mr/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergInputFormat.java
##########
@@ -517,20 +411,20 @@ private Record withIdentityPartitionColumns(
}
private static Table findTable(Configuration conf) {
- String path = conf.get(TABLE_PATH);
+ String path = conf.get(InputFormatConfig.TABLE_PATH);
Preconditions.checkArgument(path != null, "Table path should not be null");
if (path.contains("/")) {
HadoopTables tables = new HadoopTables(conf);
return tables.load(path);
}
- String catalogFuncClass = conf.get(CATALOG);
+ String catalogFuncClass = conf.get(InputFormatConfig.CATALOG);
if (catalogFuncClass != null) {
Function<Configuration, Catalog> catalogFunc = (Function<Configuration,
Catalog>)
- DynConstructors.builder(Function.class)
- .impl(catalogFuncClass)
- .build()
- .newInstance();
+ DynConstructors.builder(Function.class)
+ .impl(catalogFuncClass)
+ .build()
+ .newInstance();
Review comment:
Yes, definitely.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
