prodeezy commented on issue #617: URL: https://github.com/apache/iceberg/issues/617#issuecomment-645564962
Looks like @fbocse and @rdblue had discussed metrics library integration on this thread [1] in which this was the last thing suggested: > I'm not sure what I would want from DropWizard metrics. Most of the things we want to time happen just a few times in a job and are specific to a table. > > For example, we want to know how long a particular query takes to plan. That is dependent on how large the table is and what filters were applied. That's why we've added a way to register listeners that can log those scan events for later analysis. > > I think I would continue with this approach rather than adding a metrics library. The events that we want to time have to be grouped by table and need to be gathered from many runs of a job or a query. So it makes more sense to improve the events that are generated and the data those events contain. @aokolnychyi Do we feel this approach addresses this or are there gaps? [1] - https://lists.apache.org/x/thread.html/9e0f985cd471938f355107eea82065728b0dc047d464eba49d30e666@%3Cdev.iceberg.apache.org%3E ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
