odysa commented on code in PR #185:
URL: https://github.com/apache/iceberg-rust/pull/185#discussion_r1477362498
##########
crates/iceberg/src/spec/table_metadata.rs:
##########
@@ -676,9 +690,10 @@ pub(super) mod _serde {
}
}
- impl From<TableMetadata> for TableMetadataV1 {
- fn from(v: TableMetadata) -> Self {
- TableMetadataV1 {
+ impl TryFrom<TableMetadata> for TableMetadataV1 {
+ type Error = Error;
+ fn try_from(v: TableMetadata) -> Result<Self, Error> {
Review Comment:
Well, cuz I want make 2 separate PRs -- 1 for `serialize` and 1 for removing
`expect` . I should really mention it before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
