rdblue commented on code in PR #9675:
URL: https://github.com/apache/iceberg/pull/9675#discussion_r1483557926
##########
spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala:
##########
@@ -115,7 +124,16 @@ case class RewriteViewCommands(spark: SparkSession)
extends Rule[LogicalPlan] wi
"tempObjName" -> nameParts.quoted))
}
- // TODO: check for temp function names
+ val tempFunctions = collectTemporaryFunctions(child)
+ tempFunctions.foreach { functionName =>
Review Comment:
This is only going to be able to throw one error right? Why use `foreach`?
I'd prefer to raise an exception with an error message that we control and
that has all of the temporary functions listed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
