aokolnychyi commented on code in PR #9611: URL: https://github.com/apache/iceberg/pull/9611#discussion_r1484744762
########## api/src/main/java/org/apache/iceberg/actions/RewriteDataFiles.java: ########## @@ -52,6 +52,13 @@ public interface RewriteDataFiles int PARTIAL_PROGRESS_MAX_COMMITS_DEFAULT = 10; + /** Review Comment: Not directly related to this change but I wonder whether we should throw an exception if all jobs fail. That would mean nothing was compacted. I think @RussellSpitzer had some ideas around this. Thoughts, @manuzhang @RussellSpitzer @szehon-ho @amogh-jahagirdar @nastra? Overall, it seems reasonable to me to have such a config. I'll check the implementation in detail later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
