edgarRd edited a comment on issue #1116: URL: https://github.com/apache/iceberg/issues/1116#issuecomment-645643279
Thanks @chenjunjiedada, I was able to reproduce. I've been looking into this and I think https://github.com/apache/iceberg/commit/bca6380c56469c01f4eb02cb91f905dd57ad03d3 seems to fix both test cases as they are. However, I added a test case https://github.com/apache/iceberg/commit/e61cc6187c6a13b7913f66f548f4be9d05d2a717 for multiple timezones on `TestLocalScan testFilterWithDateAndTimestamp` and there seems to be something wrong going on: 1. Test runs fine for `America/Los_Angeles` passes 2. Test runs fine for `Europe/London` fails ``` org.apache.iceberg.data.TestLocalScan > testFilterWithDateAndTimestamp[1] FAILED java.lang.AssertionError: TZ: Europe/London at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.assertTrue(Assert.java:41) at org.apache.iceberg.data.TestLocalScan.testFilterWithDateAndTimestamp(TestLocalScan.java:498) ``` Values: ``` -- 1. America/Los_Angeles run Date min: -136246 Date max: 134321 -- 2. Europe/London run (fail) Date min: -136246 Date max: 134321 Record(1986-01-30T08:11:32.189299Z, 1995-05-15T23:02:42.319212, 1596-12-21, 00:29:18.577901) ``` If I switch the order of the tests, the second TZ test keeps failing (different timezone as the failed test before): ``` org.apache.iceberg.data.TestLocalScan > testFilterWithDateAndTimestamp[1] FAILED java.lang.AssertionError: TZ: America/Los_Angeles at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.assertTrue(Assert.java:41) at org.apache.iceberg.data.TestLocalScan.testFilterWithDateAndTimestamp(TestLocalScan.java:493) ``` Values: ``` 1. Europe/London run Date min: -136246 Date max: 134321 2. America/Los_Angeles run (fail) Date min: -136247 Date max: 134320 Record(1936-02-12T14:24:11.970343Z, 1962-08-02T07:28:37.107299, 2337-10-05, 00:15:29.965042) ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
