tomtongue commented on code in PR #9670:
URL: https://github.com/apache/iceberg/pull/9670#discussion_r1487313598
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/SparkRowLevelOperationsTestBase.java:
##########
@@ -69,41 +72,30 @@
import org.apache.spark.sql.Row;
import org.apache.spark.sql.catalyst.analysis.NoSuchTableException;
import org.apache.spark.sql.execution.SparkPlan;
-import org.junit.Assert;
-import org.junit.runner.RunWith;
-import org.junit.runners.Parameterized;
-import org.junit.runners.Parameterized.Parameters;
+import org.junit.jupiter.api.extension.ExtendWith;
-@RunWith(Parameterized.class)
-public abstract class SparkRowLevelOperationsTestBase extends
SparkExtensionsTestBase {
+@ExtendWith(ParameterizedTestExtension.class)
+public abstract class SparkRowLevelOperationsTestBase extends
ExtensionsTestBase {
private static final Random RANDOM = ThreadLocalRandom.current();
- protected final String fileFormat;
- protected final boolean vectorized;
- protected final String distributionMode;
- protected final boolean fanoutEnabled;
- protected final String branch;
- protected final PlanningMode planningMode;
-
- public SparkRowLevelOperationsTestBase(
- String catalogName,
- String implementation,
- Map<String, String> config,
- String fileFormat,
- boolean vectorized,
- String distributionMode,
- boolean fanoutEnabled,
- String branch,
- PlanningMode planningMode) {
- super(catalogName, implementation, config);
- this.fileFormat = fileFormat;
- this.vectorized = vectorized;
- this.distributionMode = distributionMode;
- this.fanoutEnabled = fanoutEnabled;
- this.branch = branch;
- this.planningMode = planningMode;
- }
+ @Parameter(index = 3)
+ protected String fileFormat;
Review Comment:
Agree. Let me do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
