pvary commented on code in PR #9735:
URL: https://github.com/apache/iceberg/pull/9735#discussion_r1492833338
##########
core/src/main/java/org/apache/iceberg/MetadataTableUtils.java:
##########
@@ -32,9 +32,16 @@ public static boolean hasMetadataTableName(TableIdentifier
identifier) {
public static Table createMetadataTableInstance(Table table,
MetadataTableType type) {
if (table instanceof BaseTable) {
return createMetadataTableInstance(table,
metadataTableName(table.name(), type), type);
+ } else if (table instanceof HasTableOperations) {
Review Comment:
I would keep it as it is. If the incoming table implements
`HasTableOperations` we can create a metadata table above that, so IMHO it
should be ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
