jun-he edited a comment on pull request #922: URL: https://github.com/apache/iceberg/pull/922#issuecomment-650829640
@rdblue thanks for the comment. I address the comments and update the PR accordingly. In this change, `UpdatePartitionSpec` now ignores all soft-deleted fields in `V1` and then applies all changes to create a `V2` partition spec. After that, it then fill each of partition filed id gaps with a `VoidTransform` field. In this way, we can also support partition spec evolution, e.g. - reuse a field id previously removed in V1 - keep spec concise without useless trailing void fields if needed Additionally, it does not need to consider `V1` case before committing and make the code cleaner and easier to read. Can you please take another look and let me know your comments? Thanks! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
