rdblue commented on a change in pull request #1103:
URL: https://github.com/apache/iceberg/pull/1103#discussion_r448477463
##########
File path: mr/src/test/java/org/apache/iceberg/mr/mapred/TestTableResolver.java
##########
@@ -111,4 +111,21 @@ public void resolveTableFromPropertiesDefault() throws
IOException {
Assert.assertEquals(tableLocation.getAbsolutePath(), table.location());
}
+ @Test(expected = UnsupportedOperationException.class)
+ public void resolveTableFromConfigurationHiveCatalog() throws IOException {
+ Configuration conf = new Configuration();
+ conf.set(InputFormatConfig.CATALOG_NAME, InputFormatConfig.HIVE_CATALOG);
+ conf.set(InputFormatConfig.TABLE_NAME, "table_a");
+
+ TableResolver.resolveTableFromConfiguration(conf);
+ }
+
+ @Test(expected = NullPointerException.class)
Review comment:
We usually prefer using `AssertHelpers.assertThrows` here, but this is
minor since you don't need to check that other state has not been modified
after the failure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
