nastra commented on code in PR #9895:
URL: https://github.com/apache/iceberg/pull/9895#discussion_r1516434260
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -226,6 +226,12 @@ public void renameTable(TableIdentifier from,
TableIdentifier originalTo) {
throw new NoSuchTableException("Invalid identifier: %s", from);
}
+ if (!namespaceExists(originalTo.namespace())) {
Review Comment:
While reviewing https://github.com/apache/iceberg/pull/9852 I noticed that
there's no such check in Hive that checks whether that namespace exists and
Hive would just fail with a RuntimeException
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
