rdblue commented on code in PR #9890:
URL: https://github.com/apache/iceberg/pull/9890#discussion_r1516572818
##########
core/src/main/java/org/apache/iceberg/inmemory/InMemoryCatalog.java:
##########
@@ -395,7 +395,9 @@ public void doCommit(TableMetadata base, TableMetadata
metadata) {
String oldLocation = base == null ? null : base.metadataFileLocation();
synchronized (InMemoryCatalog.this) {
- if (null == base && !namespaceExists(tableIdentifier.namespace())) {
+ if (null == base
+ && !namespaceExists(tableIdentifier.namespace())
+ && !tableIdentifier.namespace().isEmpty()) {
Review Comment:
Why do we need to check for empty here? Shouldn't this be consistent with
`namespaceExists` so that method covers it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
