massdosage commented on a change in pull request #1103:
URL: https://github.com/apache/iceberg/pull/1103#discussion_r448814275



##########
File path: mr/src/test/java/org/apache/iceberg/mr/mapred/TestTableResolver.java
##########
@@ -111,4 +111,21 @@ public void resolveTableFromPropertiesDefault() throws 
IOException {
     Assert.assertEquals(tableLocation.getAbsolutePath(), table.location());
   }
 
+  @Test(expected = UnsupportedOperationException.class)
+  public void resolveTableFromConfigurationHiveCatalog() throws IOException {
+    Configuration conf = new Configuration();
+    conf.set(InputFormatConfig.CATALOG_NAME, InputFormatConfig.HIVE_CATALOG);
+    conf.set(InputFormatConfig.TABLE_NAME, "table_a");
+
+    TableResolver.resolveTableFromConfiguration(conf);
+  }
+
+  @Test(expected = NullPointerException.class)

Review comment:
       Since the above is almost certainly going to be refactored when we merge 
more logic between the two InputFormats we can tackle this then.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to