rdblue commented on a change in pull request #1156:
URL: https://github.com/apache/iceberg/pull/1156#discussion_r449194344



##########
File path: 
hive/src/test/java/org/apache/iceberg/hive/HiveCreateReplaceTableTest.java
##########
@@ -155,7 +155,7 @@ public void testReplaceTableTxn() {
     txn.commitTransaction();
 
     Table table = catalog.loadTable(TABLE_IDENTIFIER);
-    Assert.assertEquals("Partition spec should match", 
PartitionSpec.unpartitioned(), table.spec());
+    Assert.assertEquals("Partition spec should be unpartitioned", 0, 
table.spec().fields().size());

Review comment:
       I should note that this needed to be updated because the spec's ID 
didn't match, causing the test to fail.
   
   `PartitionSpec.unpartitioned()` doesn't necessarily have the right ID for a 
given table. We primarily use it when creating tables, where the spec gets 
rebuilt and assigned the right ID.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to