rdblue commented on a change in pull request #1161:
URL: https://github.com/apache/iceberg/pull/1161#discussion_r449808864
##########
File path: spark/src/main/java/org/apache/iceberg/actions/BaseAction.java
##########
@@ -30,8 +30,11 @@ protected String metadataTableName(MetadataTableType type) {
String tableName = table().toString();
if (tableName.contains("/")) {
return tableName + "#" + type;
- } else if (tableName.startsWith("hadoop.") ||
tableName.startsWith("hive.")) {
- // HiveCatalog and HadoopCatalog prepend a logical name which we need to
drop for Spark 2.4
+ } else if (tableName.startsWith("hadoop.")) {
+ // Load a path by HadoopCatalog or HadoopTables
Review comment:
How about "for HadoopCatalog tables, use the table location to load the
metadata table because IcebergCatalog uses HiveCatalog when the table is
identified by name".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
