rdblue commented on a change in pull request #1169:
URL: https://github.com/apache/iceberg/pull/1169#discussion_r449917364
##########
File path:
api/src/main/java/org/apache/iceberg/expressions/InclusiveMetricsEvaluator.java
##########
@@ -102,7 +102,15 @@ private boolean eval(ContentFile<?> file) {
this.lowerBounds = file.lowerBounds();
this.upperBounds = file.upperBounds();
- return ExpressionVisitors.visitEvaluator(expr, this);
+ try {
+ return ExpressionVisitors.visitEvaluator(expr, this);
+ } finally {
+ // allow temporary state to be collected because this is in a
thread-local
+ this.valueCounts = null;
Review comment:
That sounds good to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
