danielcweeks commented on code in PR #10007:
URL: https://github.com/apache/iceberg/pull/10007#discussion_r1534831074
##########
core/src/main/java/org/apache/iceberg/FastAppend.java:
##########
@@ -43,6 +44,7 @@ class FastAppend extends SnapshotProducer<AppendFiles>
implements AppendFiles {
private final PartitionSpec spec;
private final SnapshotSummary.Builder summaryBuilder =
SnapshotSummary.builder();
private final List<DataFile> newFiles = Lists.newArrayList();
+ private final CharSequenceSet newFilePaths = CharSequenceSet.empty();
Review Comment:
Seems like there are issues with implementing hashCode/equals in that there
may be different contexts where we only care about the path vs. the entire
object representation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
