nastra commented on code in PR #10001:
URL: https://github.com/apache/iceberg/pull/10001#discussion_r1535418537
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java:
##########
@@ -76,11 +138,11 @@ default boolean exposeInHmsProperties() {
return maxHiveTablePropertySize() > 0;
}
- default void setSchema(TableMetadata metadata, Map<String, String>
parameters) {
Review Comment:
we need to keep the original method (for backwards compatibiliy), but the
method can refer to the new `setSchema()` method:
```
default void setSchema(TableMetadata metadata, Map<String, String>
parameters) {
setSchema(metadata.schema(), parameters);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
