JingsongLi opened a new pull request #1173: URL: https://github.com/apache/iceberg/pull/1173
This PR wants to import https://github.com/apache/iceberg/pull/1096 ### Use `LogicalTypeVisitor` Flink has `LogicalTypeVisitor` and `DataTypeVisitor`, they are very useful for visiting types. We don't implement a custom visitor based on `instanceOf`, it's error prone and not very elegant. And for FieldsDataType, it not has a good design in 1.9 and 1.10, so in Flink 1.11, it has been refactored to be removed getFieldDataTypes. So I think maybe a LogicalTypeVisitor is enough, since we never touch the physical information in the DataTypes. ### Support MultisetType A `CollectionDataType` may be `MultisetType` too. We can map it to Map<T, Integer>. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
