danielcweeks commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1556366558
########## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ########## @@ -274,14 +277,34 @@ public void setConf(Object newConf) { @Override public List<TableIdentifier> listTables(SessionContext context, Namespace ns) { checkNamespaceIsValid(ns); + Map<String, String> queryParams = Maps.newHashMap(); Review Comment: I feel like this could be consolidated using a `do ... while (...)` since we always need to make a single call. That might simplify and prevent having two separate call paths. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org