aokolnychyi commented on code in PR #9455:
URL: https://github.com/apache/iceberg/pull/9455#discussion_r1561889535


##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java:
##########
@@ -117,7 +119,7 @@ public class SparkTable
           .build();
 
   private final Table icebergTable;
-  private final Long snapshotId;

Review Comment:
   This should be reverted.



##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java:
##########
@@ -301,7 +305,9 @@ public RowLevelOperationBuilder 
newRowLevelOperationBuilder(RowLevelOperationInf
   @Override
   public boolean canDeleteWhere(Predicate[] predicates) {
     Preconditions.checkArgument(
-        snapshotId == null, "Cannot delete from table at a specific snapshot: 
%s", snapshotId);
+        branch != null || snapshotId == null,

Review Comment:
   This should be reverted.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to