tshauck commented on code in PR #324:
URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1562767139
##########
Cargo.toml:
##########
@@ -21,6 +21,7 @@ members = [
"crates/catalog/*",
"crates/examples",
"crates/iceberg",
+ "crates/integrations",
Review Comment:
Updating the integrations to be datafusion specific looks good to me. For
the actual datafusion dependency, you could move that into the Cargo.toml of
the new datafusion subcrate itself. So e.g...
```toml
[dependencies]
dashmap = { workspace = true }
datafusion = "37.0.0"
futures = { workspace = true }
iceberg = { workspace = true }
log = { workspace = true }
tokio = { workspace = true }
```
I think it's generally considered better to scope subcrate specific
dependencies to the crate that needs it. I'm sorry for muddying the waters via
the feature suggestion, but then I'm not sure the additional complexity of it
would be needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
