rdblue commented on a change in pull request #1182: URL: https://github.com/apache/iceberg/pull/1182#discussion_r453112078
########## File path: flink/src/test/java/org/apache/iceberg/flink/FlinkCatalogTestBase.java ########## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.flink; + +import java.io.File; +import java.io.IOException; +import java.util.HashMap; +import java.util.Map; +import org.apache.flink.table.api.EnvironmentSettings; +import org.apache.flink.table.api.TableEnvironment; +import org.apache.flink.util.ArrayUtils; +import org.apache.iceberg.catalog.Catalog; +import org.apache.iceberg.catalog.Namespace; +import org.apache.iceberg.catalog.SupportsNamespaces; +import org.apache.iceberg.hadoop.HadoopCatalog; +import org.apache.iceberg.relocated.com.google.common.base.Joiner; +import org.junit.After; +import org.junit.AfterClass; +import org.junit.Assert; +import org.junit.BeforeClass; +import org.junit.runner.RunWith; +import org.junit.runners.Parameterized; + +@RunWith(Parameterized.class) +public abstract class FlinkCatalogTestBase extends FlinkTestBase { + + protected static final String DATABASE = "db"; + private static File warehouse = null; + + @BeforeClass + public static void createWarehouse() throws IOException { + FlinkCatalogTestBase.warehouse = File.createTempFile("warehouse", null); + Assert.assertTrue(warehouse.delete()); + } + + @AfterClass + public static void dropWarehouse() { + if (warehouse != null && warehouse.exists()) { + warehouse.delete(); + } + } + + @Parameterized.Parameters + public static Object[][] parameters() { + return new Object[][] { + new Object[] { "testhive", new String[0] }, + new Object[] { "testhadoop", new String[0] }, + new Object[] { "testhadoop", new String[] { "l0", "l1" }}, + }; + } + + protected final TableEnvironment tEnv = + TableEnvironment.create(EnvironmentSettings.newInstance().useBlinkPlanner().inBatchMode().build()); + + protected final String catalogName; + protected final String[] baseNamespace; + protected final Catalog validationCatalog; + protected final SupportsNamespaces validationNamespaceCatalog; + protected final org.apache.flink.table.catalog.Catalog flinkCatalog; + + protected final String flinkIdentifier; + protected final Namespace icebergNamespace; + protected final boolean isHadoopCatalog; + + public FlinkCatalogTestBase(String catalogName, String[] baseNamespace) { + this.catalogName = catalogName; + this.baseNamespace = baseNamespace; + this.isHadoopCatalog = catalogName.equals("testhadoop"); + this.validationCatalog = isHadoopCatalog ? + new HadoopCatalog(hiveConf, "file:" + warehouse) : + catalog; + this.validationNamespaceCatalog = (SupportsNamespaces) validationCatalog; + + Map<String, String> config = new HashMap<>(); + config.put("type", "iceberg"); + config.put(FlinkCatalogFactory.ICEBERG_CATALOG_TYPE, isHadoopCatalog ? "hadoop" : "hive"); + config.put(FlinkCatalogFactory.HADOOP_WAREHOUSE_LOCATION, "file:" + warehouse); + if (baseNamespace.length > 0) { + config.put(FlinkCatalogFactory.BASE_NAMESPACE, Joiner.on(".").join(baseNamespace)); + } + + FlinkCatalogFactory factory = new FlinkCatalogFactory() { + @Override + protected Catalog buildIcebergCatalog(String name, Map<String, String> options) { + // Flink hadoop configuration depends on system env, it is quiet hard to set from testing. So directly pass + // correct hadoop configuration. + return super.buildIcebergCatalog(name, options, hiveConf); + } + }; + flinkCatalog = factory.createCatalog(catalogName, config); + tEnv.registerCatalog(catalogName, flinkCatalog); + + this.flinkIdentifier = catalogName + "." + DATABASE; + this.icebergNamespace = Namespace.of(ArrayUtils.concat(baseNamespace, new String[] { DATABASE })); + } + + @After Review comment: Won't this close the catalog after every test method? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
