nastra commented on code in PR #10130:
URL: https://github.com/apache/iceberg/pull/10130#discussion_r1565251166
##########
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/data/TestRowProjection.java:
##########
@@ -37,19 +41,17 @@
import org.apache.iceberg.relocated.com.google.common.collect.Maps;
import org.apache.iceberg.types.Comparators;
import org.apache.iceberg.types.Types;
-import org.junit.Assert;
-import org.junit.Rule;
-import org.junit.Test;
-import org.junit.rules.TemporaryFolder;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.io.TempDir;
public class TestRowProjection {
Review Comment:
In the Flink codebase we need to make sure that the same code changes are
being applied across all 3 versions. So if you're touching this file here, you
would also need to make sure to apply the same changes for the other Flink
versions.
This can be either done within the same PR or in an immediate follow-up that
backports the same changes to earlier versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]