aokolnychyi commented on code in PR #10128:
URL: https://github.com/apache/iceberg/pull/10128#discussion_r1567966520


##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestSparkSessionCatalog.java:
##########
@@ -98,4 +103,20 @@ public void testLoadFunction() {
 
     // TODO: fix loading Iceberg built-in functions in SessionCatalog
   }
+
+  @Test
+  public void testDropHiveTable() throws NoSuchTableException {

Review Comment:
   The test is valid and highlights the problem. However, I think the right fix 
would be in `HiveCatalog`. Let me check that part.



##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestSparkSessionCatalog.java:
##########
@@ -98,4 +103,20 @@ public void testLoadFunction() {
 
     // TODO: fix loading Iceberg built-in functions in SessionCatalog
   }
+
+  @Test
+  public void testDropHiveTable() throws NoSuchTableException {

Review Comment:
   The test is valid and highlights the problem. However, I think the right fix 
would be in `HiveCatalog`.
   Let me check that part.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to