openinx commented on a change in pull request #1197:
URL: https://github.com/apache/iceberg/pull/1197#discussion_r454180115
##########
File path: orc/src/main/java/org/apache/iceberg/orc/OrcFileAppender.java
##########
@@ -146,8 +146,8 @@ private static Writer newOrcWriter(OutputFile file,
}
@SuppressWarnings("unchecked")
- private static <D> OrcValueWriter<D> newOrcValueWriter(
- TypeDescription schema, Function<TypeDescription, OrcValueWriter<?>>
createWriterFunc) {
- return (OrcValueWriter<D>) createWriterFunc.apply(schema);
+ private static <D> OrcRowWriter<D> newOrcValueWriter(
Review comment:
Thanks for your reminding, Good point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
