nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1587206338
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -228,6 +230,12 @@ public void initialize(String name, Map<String, String>
unresolved) {
client, tokenRefreshExecutor(), token,
expiresAtMillis(mergedProps), catalogAuth);
}
+ this.restPageSize = PropertyUtil.propertyAsNullableInt(mergedProps,
REST_PAGE_SIZE);
+ if (restPageSize != null) {
+ Preconditions.checkArgument(
+ restPageSize > 0, "Invalid value for pageSize, must be a positive
integer");
Review Comment:
```suggestion
restPageSize > 0, "Invalid value for %s, must be a positive
integer", REST_PAGE_SIZE);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
