JingsongLi commented on a change in pull request #1173:
URL: https://github.com/apache/iceberg/pull/1173#discussion_r454744290
##########
File path: flink/src/test/java/org/apache/iceberg/flink/TestFlinkSchemaUtil.java
##########
@@ -54,21 +54,22 @@ public void testConvertFlinkSchemaToIcebergSchema() {
.field("decimal", DataTypes.DECIMAL(2, 2))
.field("decimal2", DataTypes.DECIMAL(38, 2))
.field("decimal3", DataTypes.DECIMAL(10, 1))
+ .field("multiset", DataTypes.MULTISET(DataTypes.STRING().notNull()))
Review comment:
Just like a nullable key in Map, because the default behavior in Flink
is nullable key, we support its conversion:
- in the conversion of Flink type to Iceberg type, just ignore the nullable
of key.
- in the conversion of Iceberg type to Flink type, the nullable of key
becomes false.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
