aokolnychyi commented on code in PR #10309:
URL: https://github.com/apache/iceberg/pull/10309#discussion_r1597026741
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkConfParser.java:
##########
@@ -220,14 +228,10 @@ public ThisT tableProperty(String name) {
}
protected T parse(Function<String, T> conversion, T defaultValue) {
- if (!optionNames.isEmpty()) {
- for (String optionName : optionNames) {
- // use lower case comparison as DataSourceOptions.asMap() in Spark 2
returns a lower case
- // map
- String optionValue =
options.get(optionName.toLowerCase(Locale.ROOT));
- if (optionValue != null) {
- return conversion.apply(optionValue);
- }
+ for (String optionName : optionNames) {
+ String optionValue = options.get(optionName);
Review Comment:
Removed the explicit conversion to lower case and obsolete comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
