syun64 commented on PR #725: URL: https://github.com/apache/iceberg-python/pull/725#issuecomment-2106452174
Hi @ndrluis thank you for working on this PR. What are your thoughts on aligning the implementation with the way [create_table_if_not_exists](https://github.com/apache/iceberg-python/blob/main/pyiceberg/catalog/__init__.py#L342) method is currently implemented in the abstract base class `Catalog`? The benefit I see with this approach is that we will only have to implement it once in the abstract base class, instead of having to make the changes across different catalog implementations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
