openinx edited a comment on issue #1215: URL: https://github.com/apache/iceberg/issues/1215#issuecomment-660777984
@chenjunjiedada +1, the flink data type is not strickly mapping to one kinds of java data type, it's better to create a separate readers and writers to handle the differences. Supporting both `Row` and `RowData` in flink data stream is also necessary (as @JingsongLi said) because flink 1.11 have turned its table row data type to `RowData`, I've prepared a patch in my own repo to abstract a `IcebergStreamWrter` so that we could accept the generic data type in the stream ([commit](https://github.com/openinx/incubator-iceberg/commit/78fb6fe9b37f31a7eac14368e501535345953a92#diff-2e349ce4ab68643aa0f311250e745edfR49)), I will update the pull request https://github.com/apache/iceberg/pull/1145, once its dependency PR https://github.com/apache/iceberg/pull/1213 get merged. Thanks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
