HonahX commented on code in PR #683: URL: https://github.com/apache/iceberg-python/pull/683#discussion_r1620130553
########## tests/integration/test_writes/test_writes.py: ########## @@ -609,17 +610,18 @@ def test_write_and_evolve(session_catalog: Catalog, format_version: int) -> None @pytest.mark.integration [email protected]("format_version", [2]) -def test_create_table_transaction(session_catalog: Catalog, format_version: int) -> None: - if format_version == 1: [email protected]("format_version", [1, 2]) [email protected]('catalog', [pytest.lazy_fixture('session_catalog_hive'), pytest.lazy_fixture('session_catalog')]) Review Comment: Our current setting is ```toml [format] quote-style = "double" ``` which [leave quotes unchanged](https://docs.astral.sh/ruff/settings/#format_quote-style). I changed it to "double" and found that 39 files need to be re-formatted. I've created a separete PR to give it a try: https://github.com/apache/iceberg-python/pull/781 I will investigate this issue further if the test fails :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
