RussellSpitzer commented on a change in pull request #1211: URL: https://github.com/apache/iceberg/pull/1211#discussion_r457677975
########## File path: spark/src/main/java/org/apache/iceberg/actions/ExpireSnapshotsAction.java ########## @@ -0,0 +1,260 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.actions; + +import java.io.IOException; +import java.io.UncheckedIOException; +import java.util.HashSet; +import java.util.LinkedList; +import java.util.Map; +import java.util.Set; +import java.util.concurrent.atomic.AtomicReference; +import java.util.function.Consumer; +import org.apache.iceberg.ExpireSnapshots; +import org.apache.iceberg.HasTableOperations; +import org.apache.iceberg.ManifestEntry; +import org.apache.iceberg.ManifestFile; +import org.apache.iceberg.ManifestFiles; +import org.apache.iceberg.ManifestReader; +import org.apache.iceberg.PartitionSpec; +import org.apache.iceberg.Table; +import org.apache.iceberg.TableMetadata; +import org.apache.iceberg.TableOperations; +import org.apache.iceberg.exceptions.NotFoundException; +import org.apache.iceberg.io.FileIO; +import org.apache.iceberg.relocated.com.google.common.base.Joiner; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList; +import org.apache.iceberg.spark.SparkUtil; +import org.apache.iceberg.util.ExpireSnapshotUtil; +import org.apache.iceberg.util.ExpireSnapshotUtil.ManifestExpirationChanges; +import org.apache.iceberg.util.ExpireSnapshotUtil.SnapshotExpirationChanges; +import org.apache.iceberg.util.Tasks; +import org.apache.iceberg.util.ThreadPools; +import org.apache.spark.api.java.JavaRDD; +import org.apache.spark.api.java.JavaSparkContext; +import org.apache.spark.broadcast.Broadcast; +import org.apache.spark.sql.SparkSession; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class ExpireSnapshotsAction extends BaseAction<ExpireSnapshotResults> { + + private static final Logger LOG = LoggerFactory.getLogger(ExpireSnapshotsAction.class); + + private final Table table; + private final TableOperations ops; + private final ExpireSnapshots localExpireSnapshots; + private final TableMetadata base; + private SparkSession session; + + private final Consumer<String> defaultDelete = new Consumer<String>() { + @Override + public void accept(String file) { + ops.io().deleteFile(file); + } + }; + private Consumer<String> deleteFunc = defaultDelete; + + + ExpireSnapshotsAction(SparkSession session, Table table) { + this.session = session; + this.table = table; + this.ops = ((HasTableOperations) table).operations(); + this.base = ops.current(); + this.localExpireSnapshots = table.expireSnapshots().deleteExpiredFiles(false); + } + + public ExpireSnapshotsAction expireSnapshotId(long expireSnapshotId) { + localExpireSnapshots.expireSnapshotId(expireSnapshotId); + return this; + } + + public ExpireSnapshotsAction expireOlderThan(long timestampMillis) { + localExpireSnapshots.expireOlderThan(timestampMillis); + return this; + } + + public ExpireSnapshotsAction retainLast(int numSnapshots) { + localExpireSnapshots.retainLast(numSnapshots); + return this; + } + + public ExpireSnapshotsAction deleteWith(Consumer<String> newDeleteFunc) { + deleteFunc = newDeleteFunc; + return this; + } + + + @Override + protected Table table() { + return table; + } + + /** + * Execute is a synonym for commit in this implementation. Calling either commit or execute will + * launch the Spark equivalent of RemoveSnapshots. + * + * @return nothing + */ + @Override + public ExpireSnapshotResults execute() { + localExpireSnapshots.commit(); + + TableMetadata currentMetadata = ops.refresh(); + + //Locally determine which snapshots have been expired + SnapshotExpirationChanges expiredSnapshotChanges = + ExpireSnapshotUtil.getExpiredSnapshots(currentMetadata, base); + + //Locally determine which manifests will need to be scanned, reverted, deleted + ManifestExpirationChanges manifestExpirationChanges = + ExpireSnapshotUtil.determineManifestChangesFromSnapshotExpiration( + expiredSnapshotChanges.validSnapshotIds(), expiredSnapshotChanges.expiredSnapshotIds(), + currentMetadata, base, ops.io()); + + FileIO io = SparkUtil.serializableFileIO(table); + + //Going the RDD Route because our reader functions all work with full Manifest Files + JavaSparkContext javaSparkContext = JavaSparkContext.fromSparkContext(session.sparkContext()); + + JavaRDD<ManifestFile> manifestsToScan = + javaSparkContext + .parallelize(new LinkedList<>(manifestExpirationChanges.manifestsToScan())); + + JavaRDD<ManifestFile> manifestsToRevert = + javaSparkContext + .parallelize(new LinkedList<>(manifestExpirationChanges.manifestsToRevert())); + + FileIO serializableIO = SparkUtil.serializableFileIO(table); Review comment: Will do! Thanks for the heads up ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
