jackye1995 commented on code in PR #10603:
URL: https://github.com/apache/iceberg/pull/10603#discussion_r1662916466
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -176,19 +176,34 @@ public void initialize(String name, Map<String, String>
unresolved) {
long startTimeMillis =
System.currentTimeMillis(); // keep track of the init start time for
token refresh
String initToken = props.get(OAuth2Properties.TOKEN);
+ boolean hasInitToken = initToken != null;
// fetch auth and config to complete initialization
ConfigResponse config;
OAuthTokenResponse authResponse;
String credential = props.get(OAuth2Properties.CREDENTIAL);
+ boolean hasCredential = credential != null && !credential.isEmpty();
String scope = props.getOrDefault(OAuth2Properties.SCOPE,
OAuth2Properties.CATALOG_SCOPE);
Map<String, String> optionalOAuthParams =
OAuth2Util.buildOptionalParam(props);
+ if (!props.containsKey(OAuth2Properties.OAUTH2_SERVER_URI)
Review Comment:
I am doing a prototype for the refactoring, maybe let me publish a draft and
we can see how that would look like
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
