ebyhr commented on code in PR #10632:
URL: https://github.com/apache/iceberg/pull/10632#discussion_r1666513349
##########
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/source/assigner/SplitAssignerTestBase.java:
##########
@@ -101,29 +103,29 @@ private void assertAvailableFuture(
protected void assertGetNext(SplitAssigner assigner, GetSplitResult.Status
expectedStatus) {
GetSplitResult result = assigner.getNext(null);
- Assert.assertEquals(expectedStatus, result.status());
+ assertThat(result.status()).isEqualTo(expectedStatus);
switch (expectedStatus) {
case AVAILABLE:
- Assert.assertNotNull(result.split());
+ assertThat(result.split()).isNotNull();
break;
case CONSTRAINED:
case UNAVAILABLE:
- Assert.assertNull(result.split());
+ assertThat(result.split()).isNull();
break;
default:
- Assert.fail("Unknown status: " + expectedStatus);
+ fail(String.format("Unknown status: %s", expectedStatus));
Review Comment:
`String.format` seems redundant because `fail` method supports `(String
failureMessage, Object... args)`.
https://www.javadoc.io/doc/org.assertj/assertj-core/latest/org/assertj/core/api/Fail.html#fail(java.lang.String,java.lang.Object...)
> Throws an
[AssertionError](https://docs.oracle.com/javase/8/docs/api/java/lang/AssertionError.html)
with the given message built as [String.format(String,
Object...)](https://docs.oracle.com/javase/8/docs/api/java/lang/String.html#format-java.lang.String-java.lang.Object...-).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
