Xuanwo commented on code in PR #448:
URL: https://github.com/apache/iceberg-rust/pull/448#discussion_r1668391151
##########
.github/workflows/ci.yml:
##########
@@ -50,6 +50,12 @@ jobs:
- name: Cargo sort
run: make cargo-sort
+ - name: Cargo Machete
+ uses: bnjbvr/cargo-machete@main
+ with:
+ args: --with-metadata
+ continue-on-error: false
Review Comment:
> remove the dependencies using
Hi, please fail the ci as we can contributors to remove the unused deps.
##########
.github/workflows/ci.yml:
##########
@@ -50,6 +50,12 @@ jobs:
- name: Cargo sort
run: make cargo-sort
+ - name: Cargo Machete
+ uses: bnjbvr/cargo-machete@main
+ with:
+ args: --with-metadata
+ continue-on-error: false
Review Comment:
> remove the dependencies using
Hi, please fail the ci as we want contributors to remove the unused deps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
