nastra commented on code in PR #10663:
URL: https://github.com/apache/iceberg/pull/10663#discussion_r1670260939
##########
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/source/enumerator/TestContinuousSplitPlannerImplStartStrategy.java:
##########
@@ -165,11 +165,11 @@ public void
testForSpecificSnapshotTimestampStrategySnapshot2() throws IOExcepti
.startSnapshotTimestamp(1L)
.build();
- // empty table
assertThatThrownBy(
() ->
ContinuousSplitPlannerImpl.startSnapshot(
TABLE_RESOURCE.table(),
scanContextInvalidSnapshotTimestamp))
+ .as("empty table")
Review Comment:
I feel like this rather adds confusion than helping if the assertion ever
fails. Aren't we just providing an invalid snapshot timestamp and thus not
getting any snapshot back? I would just remove `.as("empty table")` here and in
the other assertions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
