rdblue commented on a change in pull request #1184:
URL: https://github.com/apache/iceberg/pull/1184#discussion_r459826175
##########
File path: api/src/main/java/org/apache/iceberg/types/Types.java
##########
@@ -219,16 +220,30 @@ public static TimestampType withoutZone() {
return INSTANCE_WITHOUT_ZONE;
}
+ /**
+ * @return Timestamp type (with timezone) represented as INT96. This is
only added for compatibility reasons
+ * and can only be written using a Spark's ParquetWriteSupport. Writing
this type should be avoided.
+ */
Review comment:
I don't think we should change the type system to support this. INT96
may be something that we can read, but Iceberg cannot write it, per the spec.
Was this needed to build the tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
