dramaticlly commented on PR #10679: URL: https://github.com/apache/iceberg/pull/10679#issuecomment-2223373221
> I think this is fine, I mentioned this another similar PR though so I thought I would note it here as well. We need to make sure our test case now runs with Filesystems that both support and don't support BulkOperations otherwise we have an untested branch. > > > > Is that the case here? We may need to start parameterizing the tests again along the axis of File System Capabilities. I think so, I was using testMetadataFileLocationsRemovalAfterCommit in CatalogTests.java to verify the correctness of this change. It was parametrized to test various catalog, where in memory catalog is using in-memory fileIO (not support bulk deletion) and hive catalog is using Hadoop fileIO (support bulk deletion), plus various other catalogs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
